Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project page updates #160

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Project page updates #160

merged 5 commits into from
Nov 6, 2024

Conversation

smalex-z
Copy link

@smalex-z smalex-z commented Oct 31, 2024

Describe your changes

Added projects grid to the projects page. Default is 3 projects per row, which gets reduced to 2 past the breakpoint and eventually 1. Routing isn't implemented yet, but URLs work. Dummy data is stored in projectData.js.

Issue ticket number and link

Completes #140

Checklist before requesting a review

  • I have performed a self-review of my code

accesslint[bot]

This comment was marked as resolved.

@smalex-z
Copy link
Author

smalex-z commented Nov 2, 2024

Future style changes to be made - in particular, cover images to be assigned after discussion with design

@smalex-z smalex-z requested a review from justinsheu November 2, 2024 20:31
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@justinsheu justinsheu force-pushed the project-page-updates branch from c1c1e22 to 3807525 Compare November 6, 2024 08:36
Copy link

@justinsheu justinsheu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, rebased and force pushed so merge should work now?

@justinsheu justinsheu merged commit 0e5b10c into new_site_dev Nov 6, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants