Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ratelimits #10

Merged
merged 12 commits into from
Sep 23, 2024
Merged

Implement ratelimits #10

merged 12 commits into from
Sep 23, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Sep 23, 2024

Summary

This PR aims to implement an robust ratelimiting system. This is done now so we can focus on building the actual API next. Although this ratelimiter implementation does use slowapi, I think it will be fine for now. The only other library basically doesn't even work at all from the last time I checked. Although this library does block the event loop, hopefully it shouldn't accept the performance of the app.

In addition, Redis is used here to synchronize the ratelimit cache. We could always use Redis to build an cache later on.

Types of changes

What types of changes does your code introduce to Kanae?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

Copy link

sonarcloud bot commented Sep 23, 2024

@No767 No767 merged commit 152d9ab into main Sep 23, 2024
9 checks passed
@No767 No767 deleted the noelle/ratelimits branch September 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant