Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pre-commit to v4 #16

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Migrate pre-commit to v4 #16

merged 3 commits into from
Oct 11, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Oct 11, 2024

Summary

pre-commit v4 came out pretty recently, which broke the configuration used in this project. This PR aims to upgrade to the v4 standard.

Types of changes

What types of changes does your code introduce to Kanae?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

Copy link

sonarcloud bot commented Oct 11, 2024

@No767 No767 merged commit fa8a8db into main Oct 11, 2024
9 checks passed
@No767 No767 deleted the noelle/migrate-pre-commit-v4 branch October 11, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant