Fixes version installation problems and refactors module #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
September 8, 2017 14:28
|
Thanks! I will try to review this as soon as I can. |
|
I'm interested in building on this to support awareness of environments other than the root environment. Please let me know if I can do anything to help shepherd this along, @jiffyclub. :- ) |
|
@jiffyclub did you manage to get a chance to review this? |
|
It looks fine to me, but I don't use this anymore so I'm going to take your word that it works! @colin-nolan, would you be potentially interested in taking over maintenance of this? |
|
@colin-nolan FYI the Travis run failed post-merge: https://travis-ci.org/UDST/ansible-conda/builds/335736685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially thought a fix for #17 would be simple but soon found that there is much more subtlety to the way Conda deals with package versions! Hopefully I've addressed all of the edge cases here.
This fix has turned into a rather large refactoring of the module, which also addresses a fair few problems that weren't previously reported. I've added more testing and hopefully made the code easier to work with in the future.
Sorry for making so many changes in one go!