-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance/gtfs network refactor w unit tests #86
Merged
smmaurer
merged 28 commits into
dev
from
maintenance/gtfs-network-refactor-w-unit-tests
Apr 29, 2021
Merged
Maintenance/gtfs network refactor w unit tests #86
smmaurer
merged 28 commits into
dev
from
maintenance/gtfs-network-refactor-w-unit-tests
Apr 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts and docstrings
…mat() with unit test
…mes_int to both be True for clarity
…xisting_stop_times_int are used, remove ValueError that can never happen
…e and unique_trip_id records to aid in debugging
… and fix rare case where index was removed before merge
… accept new GTFS modes 11 and 12, validate inputs, update docstring, add prints
…dd calendar and calendar_dates as optional tables
…dd calendar and calendar_dates as optional tables
smmaurer
approved these changes
Apr 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great refactor! Code looks good, and tests pass on my Mac.
(We talked offline about the Travis failures in py27 and py35. The immediate problems are upstream, and will be fixed either in PR #87 or in a subsequent one moving the tests from Travis to GitHub Actions.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance update with no substantial API changes comprised of code simplification, docstring and print updates, and unit test coverage expansion focusing on
gtfs.network.py
which include:updates to gtfs.network.py:
general updates:
Note: travis is failing in py27 and 35 for this PR due to issue with Pandana and Numpy