-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.2.dev0] Template for loading data #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmaurer
changed the title
Template for data loading
[0.2.dev0] Template for loading data
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial chunk of data i/o functionality, as described in issue #66.
New template:
urbansim_templates.io.TableFromDisk()
Template for registering data tables from csv or h5 files, to replace
datasources.py
. See docstrings and sphinx file for full documentation, which will appear online after this PR is merged.Basic usage: Create an instance of the template class and set some properties (table name, file type, path, etc). "Registering" with ModelManager saves the object to disk and creates an Orca step with instructions to set up a table. "Running" the object/step registers the Orca table. Data is read from disk lazily when it's needed.
New standard template property:
autorun
When you register a template instance with ModelManager, it now checks for a property called
autorun
. If it's present andTrue
, ModelManager will immediately "run" the step.This will be helpful for preparatory logic like this new template: If you have some table-loading steps defined in your configs directory, the tables will automatically be registered with Orca when you initialize a ModelManager session.
Data validation
The new template includes a
validate()
method that checks some basic expectations about the data that's being loaded:This gets us much of the way to either (a) automatically generating Orca "broadcasts" between tables or (b) performing table merges without needing broadcasts. See issue #78 for more on this.
Versioning
0.2.dev0
To do before merging