fix: Detect outdated notation for bootstrap attribute log-level#603
Merged
fix: Detect outdated notation for bootstrap attribute log-level#603
Conversation
Member
Author
|
@SAP/ui5-foundation Any recommendation if we should add the bootstrap attribute only to one html page and not to every test page? |
matz3
previously approved these changes
Mar 17, 2025
Member
matz3
left a comment
matz3
left a comment
There was a problem hiding this comment.
LGTM. I don't mind about adding it to every page.
flovogt
force-pushed
the
fix-detection-bootstrap-attribute-loglevel
branch
from
74c560e to
33d8809
Compare
flovogt
force-pushed
the
fix-detection-bootstrap-attribute-loglevel
branch
from
33d8809 to
e6158f2
Compare
matz3
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #602