Merged
Conversation
🔗 Resolves: #be/feat/319
jihaneol
reviewed
Apr 25, 2025
Comment on lines
65
to
68
| if (!stock.hasStock(totalQuantity)) | ||
| throw new DomainException(ErrorType.INSUFFICIENT_STOCK); | ||
|
|
||
| cart.updateQuantity(totalQuantity); |
Contributor
There was a problem hiding this comment.
동시성 문제가 있을 것 같은데 테스트 하셨나요?
Contributor
Author
There was a problem hiding this comment.
낙관적 락 추가하였습니다 테스트는 따로 브랜치 파서 진행하겠습니다!
🔗 Resolves: #be/feat/319
kiteof-park
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떤 문제를 마주했나요 ?
✨ 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료 및 회고