Skip to content

Commit

Permalink
feat(DTFS2-7779): update effective-date to effective-from
Browse files Browse the repository at this point in the history
  • Loading branch information
Mark Roberts committed Jan 28, 2025
1 parent 2d75f40 commit 154ad09
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { FACILITY_TYPE } from '@ukef/dtfs2-common';
import { validationErrorHandler } from '../../../server/utils/helpers';
import pageRenderer from '../../pageRenderer';
import { EffectiveFromViewModel } from '../../../server/types/view-models/amendments/effective-date-view-model';
import { EffectiveFromViewModel } from '../../../server/types/view-models/amendments/effective-from-view-model';

const page = 'partials/amendments/effective-from.njk';
const render = pageRenderer(page);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { HttpStatusCode } from 'axios';
import { createMocks } from 'node-mocks-http';
import { getEffectiveFrom, GetEffectiveDateRequest } from './get-effective-from';
import { MOCK_BASIC_DEAL } from '../../../utils/mocks/mock-applications';
import { EffectiveFromViewModel } from '../../../types/view-models/amendments/effective-date-view-model';
import { EffectiveFromViewModel } from '../../../types/view-models/amendments/effective-from-view-model';
import { MOCK_UNISSUED_FACILITY, MOCK_ISSUED_FACILITY } from '../../../utils/mocks/mock-facilities';
import { PortalFacilityAmendmentWithUkefIdMockBuilder } from '../../../../test-helpers/mock-amendment';
import { PORTAL_AMENDMENT_PAGES } from '../../../constants/amendments';
Expand Down Expand Up @@ -114,7 +114,7 @@ describe('getEffectiveFrom', () => {
};

expect(res._getStatusCode()).toEqual(HttpStatusCode.Ok);
expect(res._getRenderView()).toEqual('partials/amendments/effective-date.njk');
expect(res._getRenderView()).toEqual('partials/amendments/effective-from.njk');
expect(res._getRenderData()).toEqual(expectedRenderData);
expect(console.error).toHaveBeenCalledTimes(0);
});
Expand Down Expand Up @@ -151,7 +151,7 @@ describe('getEffectiveFrom', () => {
};

expect(res._getStatusCode()).toEqual(HttpStatusCode.Ok);
expect(res._getRenderView()).toEqual('partials/amendments/effective-date.njk');
expect(res._getRenderView()).toEqual('partials/amendments/effective-from.njk');
expect(res._getRenderData()).toEqual(expectedRenderData);
expect(console.error).toHaveBeenCalledTimes(0);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { userCanAmendFacility } from '../../../utils/facility-amendments.helper.
import { getAmendmentsUrl, getPreviousPage } from '../helpers/navigation.helper.ts';
import { PORTAL_AMENDMENT_PAGES } from '../../../constants/amendments.ts';
import { convertDateToDayMonthYearInput } from '../helpers/dates.helper.ts';
import { EffectiveFromViewModel } from '../../../types/view-models/amendments/effective-date-view-model.ts';
import { EffectiveFromViewModel } from '../../../types/view-models/amendments/effective-from-view-model.ts';

export type GetEffectiveDateRequest = CustomExpressRequest<{
params: { dealId: string; facilityId: string; amendmentId: string };
Expand Down

0 comments on commit 154ad09

Please sign in to comment.