feat(FN-1089): fix next report period start #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshBinns2000
requested review from
toddym42,
ChristianMcc and
francescastocco
|
Kudos, SonarCloud Quality Gate passed!
|
toddym42
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
The next report period start date was being calculated incorrectly. For example, if the next report due is April 2023, the next report period start date was being calculated as 1 April 2023 whilst it should be 1 May 2023.
Resolution
Update the utilisation report upload controller to correctly calculate the next due report period start date. Also updates component tests to reflect the expected behaviour.