Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FN-692): infrastructure improvements #2466

Conversation

francescastocco
Copy link
Contributor

Introduction ✏️

Feature environment infrastructure improvements

Resolution ✔️

  • Added what-if to bicep deploy pipeline
  • Added a pipeline for linting bicep code when pull request created against feat/stbr-infra
  • Disabled the function-apps deployment in the feature_deploy pipeline

Miscellaneous ➕

List any additional fixes or improvements.

@francescastocco francescastocco self-assigned this Dec 21, 2023
@francescastocco francescastocco added the Type: Fintech For fintech related work label Dec 21, 2023
- '.github/workflows/bicep_az_deployment_group.yml'
- '.github/workflows/bicep_deploy.yml'
- '.github/workflows/bicep_workflow_feature.yml'
- 'infrastructure/resource_group_level/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be infrastructure? Right now I assume everything is resource_group_level but would assume if we ever have any bicep that's at a subscription level we would need it here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yes, good point

.github/workflows/bicep_deploy.yml Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@francescastocco francescastocco merged commit 14f2022 into feat/stbr-infra Dec 22, 2023
5 checks passed
@francescastocco francescastocco deleted the feat/FN-692/add-what-if-to-bicep-deploy-pipeline branch December 22, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fintech For fintech related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants