Skip to content

fix: bicep refactor #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2024
Merged

fix: bicep refactor #2548

merged 3 commits into from
Jan 3, 2024

Conversation

francescastocco
Copy link
Contributor

Introduction ✏️

Refactoring the bicep I wrote when we changed connection strings to environment variables

Resolution ✔️

  • Set all tfm-api settings in trade-finance-manager-api-calculated-variables, instead of setting it twice
  • Rename tfmApiConnectionStrings module to tfmApiCalculatedVariables
  • Add condition to webapp.bicep to only set appSettings if not empty

@francescastocco francescastocco added the Type: Fintech For fintech related work label Jan 3, 2024
@francescastocco francescastocco self-assigned this Jan 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

OxonianCambion
OxonianCambion approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@OxonianCambion OxonianCambion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@francescastocco francescastocco merged commit ff32321 into feat/stbr-infra Jan 3, 2024
@francescastocco francescastocco deleted the fix/update-bicep-naming branch January 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OxonianCambion OxonianCambion OxonianCambion approved these changes

@ChristianMcc ChristianMcc Awaiting requested review from ChristianMcc

Assignees

@francescastocco francescastocco

Labels
Type: Fintech For fintech related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescastocco @OxonianCambion