feat(dtfs2 7093): Update to Tudor crown #2982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closed to merge into r1.5 (needed to rebuild public folder) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
We need to update the crown to be a tudor crown
Resolution ✔️
Kept the existing pattern for the header pages, and updated the svg following html guides here:
https://github.com/alphagov/govuk-frontend/releases/tag/v4.8.0
Miscellaneous ➕
The current setup is most likely due to the requirement to have many more additional class tags on the header element, so I've kept the file the same for now.
I've not been able to test favicon is updated -- we should make sure this is the case in (and remember that favicons cache oddly)