Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DTFS2-7091): Portal deal status does not reflect submission type #2984

Conversation

abhi-markan
Copy link
Contributor

@abhi-markan abhi-markan commented Apr 3, 2024

Introduction ✏️

Portal deal status does not accurately reflects the stage of the application as per the deal submission type.

Resolution ✔️

  • Portal deal status amendment post submission type identification.
  • Latest portal deal status fetch pre TFM stage amendment.
  • Ensure Incomplete facilit(ies) cannot be submited to the checker.
  • Added coverDateConfirmed: true property-value upon BSS/EWCS facility update when requestedCoverStartDate is being set to ensure facility can be updated when application is being submitted.

Miscellaneous ➕

  • Improved documentation.
  • Updated test cases.

@abhi-markan abhi-markan added the Type: Fix Fix label Apr 3, 2024
@abhi-markan abhi-markan self-assigned this Apr 3, 2024
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
68.6% Duplication on New Code (required ≤ 40%)

See analysis details on SonarCloud

@abhi-markan abhi-markan merged commit 994a004 into release-1.5 Apr 4, 2024
87 of 88 checks passed
@abhi-markan abhi-markan deleted the fix/DTFS2-7091-regression-mia-journey-is-not-working-as-expected branch April 4, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants