Skip to content

feat(FN-2294): send email to bank if report reconciled #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 10, 2024
Merged

feat(FN-2294): send email to bank if report reconciled #3648

merged 13 commits into from
Oct 10, 2024

Conversation

Zainzzkk
Copy link
Contributor

@Zainzzkk Zainzzkk commented Oct 7, 2024

Introduction ✏️

This PR sends an email to the bank when a report is marked as reconciled

Resolution ✔️

  • Added helper to send an email once report is reconciled
  • Added helper to generate email variables
  • Added external-api call to dtfs-central-api to send emails
  • Added unit tests

Miscellaneous ➕

  • Moved date format functions to libs/common

@Zainzzkk Zainzzkk merged commit 3ff1e91 into main Oct 10, 2024
212 of 213 checks passed
@Zainzzkk Zainzzkk deleted the feat/FN-2294 branch October 10, 2024 15:55
@abhi-markan abhi-markan mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLavender98 RLavender98 RLavender98 left review comments

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
Type: Feature feature Type: Fintech For fintech related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zainzzkk @ttbarnes @RLavender98