Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DTFS2-6892): commonise london timezone #3672

Merged
merged 22 commits into from
Oct 17, 2024

Conversation

AlexBramhill
Copy link
Contributor

@AlexBramhill AlexBramhill commented Oct 11, 2024

Introduction ✏️

As part of sso, I will need to use the london iana timezone. It is not currently commonised.

Resolution ✔️

This ticket seeks to commonise the london timezone (outside of tests which are referring to it as a string), as well as creating a IanaTimezone type.

Miscellaneous ➕

  • The IanaTimezone type is broad -- being a string. This is because calling the Intl.supportedValuesOf('timeZone') function returns a broad type (string). I do not want to overly specify this type by making a static list of iana timezones in this PR.
  • I've destructured imports as per the existing convention
  • I've tidied up mismatching require and import on some js files

@AlexBramhill AlexBramhill self-assigned this Oct 11, 2024
@AlexBramhill AlexBramhill added the Type: Feature feature label Oct 11, 2024
@AlexBramhill AlexBramhill merged commit f4c1242 into main Oct 17, 2024
212 of 213 checks passed
@AlexBramhill AlexBramhill deleted the feat/DTFS2-6892/commonise-london-timezone branch October 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants