Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-6892): move entra id to tfm api #3960

Merged

Merge branch 'main' into feat/DTFS2-6892/add-frontend-upsert-user-fun…

2f950f1
Select commit
Loading
Failed to load commit list.
Merged

feat(DTFS2-6892): move entra id to tfm api #3960

Merge branch 'main' into feat/DTFS2-6892/add-frontend-upsert-user-fun…
2f950f1
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Feb 5, 2025 in 0s

66 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 11
- Added 66
           

Complexity increasing per file
==============================
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts  1
- trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts  1
- trade-finance-manager-api/src/v1/third-party-apis/entra-id.api.get-authority-metadata-url.test.ts  1
- trade-finance-manager-api/src/v1/services/entra-id.service.get-auth-code-url.test.ts  1
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.config.mock.builder.ts  1
- trade-finance-manager-api/src/v1/services/entra-id.service.ts  2
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.api.mock.builder.ts  1
- trade-finance-manager-api/src/v1/configs/entra-id.config.ts  1
- trade-finance-manager-api/src/v1/sso/routes.ts  1
- trade-finance-manager-api/src/v1/controllers/sso.controller.ts  2
- trade-finance-manager-ui/server/services/login.service.get-auth-code-url.test.ts  1
- trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts  1
- trade-finance-manager-ui/server/services/login.service.ts  1
- trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.ts  2
         

Clones added
============
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts  1
- trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts  2
- trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts  1
- trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts  2
         

Clones removed
==============
+ trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-logout.test.ts  -1
         

See the complete overview on Codacy

Annotations

Check failure on line 1 in trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts#L1

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 6 in trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts#L6

Unsafe call of an `error` type typed value.

Check failure on line 9 in trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts#L9

Unsafe call of an `error` type typed value.

Check failure on line 3 in trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L3

Unable to resolve path to module 'node-mocks-http'.

Check failure on line 24 in trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L24

Unsafe member access .build on an `error` typed value.

Check failure on line 40 in trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L40

Unsafe array destructuring of a tuple element with an error typed value.

Check failure on line 40 in trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L40

Unsafe call of an `error` type typed value.

Check failure on line 42 in trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L42

Unsafe call of an `error` type typed value.

Check failure on line 76 in trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L76

Unsafe return of an error typed value.

Check failure on line 1 in trade-finance-manager-api/src/v1/controllers/sso.controller.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.ts#L1

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 13 in trade-finance-manager-api/src/v1/controllers/sso.controller.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.ts#L13

Unsafe argument of type `any` assigned to a parameter of type `GetAuthCodeUrlParams`.

Check failure on line 14 in trade-finance-manager-api/src/v1/controllers/sso.controller.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-api/src/v1/controllers/sso.controller.ts#L14

Unsafe call of an `error` type typed value.

Check failure on line 4 in trade-finance-manager-ui/server/controllers/auth/auth-sso/unauthenticated-auth.controller.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/auth/auth-sso/unauthenticated-auth.controller.ts#L4

Unable to resolve path to module '@ukef/dtfs2-common/schemas'.

Check failure on line 11 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L11

Unsafe assignment of an error typed value.

Check failure on line 55 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L55

Unsafe call of an `error` type typed value.

Check failure on line 55 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L55

Unsafe member access .createMocks on an `error` typed value.

Check failure on line 91 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L91

Unsafe call of an `error` type typed value.

Check failure on line 105 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L105

Unsafe assignment of an error typed value.

Check failure on line 131 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L131

Unsafe call of an `error` type typed value.

Check failure on line 131 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L131

Unsafe member access .calledWith on an `error` typed value.

Check failure on line 135 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L135

Unsafe member access .calledWith on an `error` typed value.

Check failure on line 12 in trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-logout.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-logout.test.ts#L12

Unsafe assignment of an error typed value.

Check failure on line 9 in trade-finance-manager-ui/server/services/login.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/server/services/login.service.ts#L9

Unsafe assignment of an error typed value.

Check failure on line 1 in trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts#L1

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 6 in trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts#L6

Unsafe call of an `error` type typed value.