feat(DTFS2-6892): move entra id to tfm api #3960
66 new issues (0 max.) of at least minor severity.
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 11
- Added 66
Complexity increasing per file
==============================
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts 1
- trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts 1
- trade-finance-manager-api/src/v1/third-party-apis/entra-id.api.get-authority-metadata-url.test.ts 1
- trade-finance-manager-api/src/v1/services/entra-id.service.get-auth-code-url.test.ts 1
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.config.mock.builder.ts 1
- trade-finance-manager-api/src/v1/services/entra-id.service.ts 2
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.api.mock.builder.ts 1
- trade-finance-manager-api/src/v1/configs/entra-id.config.ts 1
- trade-finance-manager-api/src/v1/sso/routes.ts 1
- trade-finance-manager-api/src/v1/controllers/sso.controller.ts 2
- trade-finance-manager-ui/server/services/login.service.get-auth-code-url.test.ts 1
- trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts 1
- trade-finance-manager-ui/server/services/login.service.ts 1
- trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.ts 2
Clones added
============
- trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts 1
- trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts 2
- trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts 1
- trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts 2
Clones removed
==============
+ trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-logout.test.ts -1
See the complete overview on Codacy
Annotations
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts#L1
Unable to resolve path to module '@ukef/dtfs2-common'.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts#L6
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/__mocks__/builders/entra-id.service.mock.builder.ts#L9
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L3
Unable to resolve path to module 'node-mocks-http'.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L24
Unsafe member access .build on an `error` typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L40
Unsafe array destructuring of a tuple element with an error typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L40
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L42
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.get-auth-code-url.test.ts#L76
Unsafe return of an error typed value.
Check failure on line 1 in trade-finance-manager-api/src/v1/controllers/sso.controller.ts
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.ts#L1
Unable to resolve path to module '@ukef/dtfs2-common'.
Check failure on line 13 in trade-finance-manager-api/src/v1/controllers/sso.controller.ts
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.ts#L13
Unsafe argument of type `any` assigned to a parameter of type `GetAuthCodeUrlParams`.
Check failure on line 14 in trade-finance-manager-api/src/v1/controllers/sso.controller.ts
codacy-production / Codacy Static Code Analysis
trade-finance-manager-api/src/v1/controllers/sso.controller.ts#L14
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/auth/auth-sso/unauthenticated-auth.controller.ts#L4
Unable to resolve path to module '@ukef/dtfs2-common/schemas'.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L11
Unsafe assignment of an error typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L55
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L55
Unsafe member access .createMocks on an `error` typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L91
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L105
Unsafe assignment of an error typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L131
Unsafe call of an `error` type typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L131
Unsafe member access .calledWith on an `error` typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-login.test.ts#L135
Unsafe member access .calledWith on an `error` typed value.
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/controllers/login/login-sso/login.controller.get-logout.test.ts#L12
Unsafe assignment of an error typed value.
Check failure on line 9 in trade-finance-manager-ui/server/services/login.service.ts
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/server/services/login.service.ts#L9
Unsafe assignment of an error typed value.
Check failure on line 1 in trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts#L1
Unable to resolve path to module '@ukef/dtfs2-common'.
Check failure on line 6 in trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts
codacy-production / Codacy Static Code Analysis
trade-finance-manager-ui/test-helpers/mocks/login.service.mock.builder.ts#L6
Unsafe call of an `error` type typed value.