feat(DTFS2-6892): update mock builder, enforce complete defaults, document mocked class methods #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-markan
deleted the
feat/DTFS2-6892/update-mock-builder-to-automatically-use-defaults
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting commits -- this is a copy of the following PR #4067
Introduction ✏️
We sometimes need to include sync methods in our mock builders that are the same implementation as the service being mocked.
This is because of the existing policy of not mocking sync methods in tests
Resolution ✔️
Make mock builders require all params of the mocked class/type to be specified
Add documentation and example for how to pass through existing implementation of mocked class to mock builder
Make mock builders automatically instantiate defaults instead of having to use
withDefaultsUpdate documentation with examples