Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FN-3669): map reported fees amount to monetary value #4142

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

sw-mattw
Copy link
Contributor

Introduction ✏️

The reported fees on the bank correction "check the information" screen needs to be formatted as a monetary value. At present, the raw number will be rendered.

Examples:

  • Before: 123, After: 123.00
  • Before: 1234.56, After: 1,234.56

Resolution ✔️

  • Updated view model "amount" type to string
  • Called monetary value formatting helper in the controller

Miscellaneous ➕

N/A

@sw-mattw sw-mattw added Type: Feature feature Type: Fintech For fintech related work labels Jan 15, 2025
@sw-mattw sw-mattw self-assigned this Jan 15, 2025
@Zainzzkk Zainzzkk merged commit 7dc2f31 into main Jan 15, 2025
237 of 238 checks passed
@Zainzzkk Zainzzkk deleted the feat/FN-3669/format-reported-fees-paid branch January 15, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature feature Type: Fintech For fintech related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants