Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7498): fetch amendments eligibility criteria from db #4155

Merged

feat(DTFS2-7621): tiny renaming

d745a4c
Select commit
Loading
Failed to load commit list.
Merged

feat(DTFS2-7498): fetch amendments eligibility criteria from db #4155

feat(DTFS2-7621): tiny renaming
d745a4c
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 23, 2025 in 0s

81 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 4
- Added 81
           

Complexity increasing per file
==============================
- dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts  1
- dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts  1
- dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts  2
         

Clones added
============
- dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts  1
- dtfs-central-api/api-tests/v1/portal-facility-amendments/amendment-patch.api-test.ts  1
- dtfs-central-api/api-tests/v1/portal-facility-amendments/amendment-put.api-test.ts  5
         

See the complete overview on Codacy

Annotations

Check failure on line 16 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts#L16

Unsafe assignment of an error typed value.

Check failure on line 26 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts#L26

Unsafe call of an `error` type typed value.

Check failure on line 35 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts#L35

Unsafe member access .ELIGIBILITY_CRITERIA_AMENDMENTS on an `error` typed value.

Check failure on line 40 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts#L40

Unsafe assignment of an error typed value.

Check failure on line 40 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.test.ts#L40

Unsafe member access .CASH on an `error` typed value.

Check failure on line 1 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L1

Unable to resolve path to module 'mongodb'.

Check failure on line 2 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L2

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 10 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L10

Unsafe call of an `error` type typed value.

Check failure on line 10 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L10

Unsafe member access .getCollection on an `error` typed value.

Check failure on line 22 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L22

Unsafe assignment of an error typed value.

Check failure on line 48 in dtfs-central-api/src/services/portal/facility-amendment.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.service.ts#L48

Unsafe call of an `error` type typed value.

Check failure on line 2 in dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts#L2

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 116 in dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts#L116

Unsafe member access .type on an `error` typed value.

Check failure on line 139 in dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts#L139

Unsafe assignment of an error typed value.

Check failure on line 141 in dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.upsertPortalFacilityAmendmentDraft.service.test.ts#L141

Unsafe member access .criteria on an `error` typed value.

Check failure on line 1 in dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts#L1

Unable to resolve path to module 'mongodb'.

Check failure on line 9 in dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts#L9

Unsafe member access .CASH on an `error` typed value.

Check failure on line 16 in dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts#L16

Unsafe assignment of an error typed value.

Check failure on line 16 in dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/test-helpers/test-data/eligibility-criteria-amendments.ts#L16

Unsafe call of an `error` type typed value.

Check failure on line 44 in gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts#L44

Unsafe member access .eligibilityCriteria on an `error` typed value.

Check failure on line 51 in gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts#L51

Unsafe assignment of an error typed value.

Check failure on line 51 in gef-ui/test-helpers/mock-amendment.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/test-helpers/mock-amendment.ts#L51

Unsafe member access .eligibilityCriteria on an `error` typed value.

Check failure on line 1 in utils/mock-data-loader/clean-all-tables-gef.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

utils/mock-data-loader/clean-all-tables-gef.js#L1

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 1 in utils/mock-data-loader/gef/eligibilityCriteriaAmendments.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

utils/mock-data-loader/gef/eligibilityCriteriaAmendments.js#L1

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 1 in utils/mock-data-loader/insert-mocks-gef.js

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

utils/mock-data-loader/insert-mocks-gef.js#L1

Unable to resolve path to module '@ukef/dtfs2-common'.