Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7498): fetch amendments eligibility criteria from db #4155

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

feat(DTFS2-7498): add tests

7b3f731
Select commit
Loading
Failed to load commit list.
Draft

feat(DTFS2-7498): fetch amendments eligibility criteria from db #4155

feat(DTFS2-7498): add tests
7b3f731
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jan 17, 2025 in 0s

30 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 30
           

Complexity increasing per file
==============================
- dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts  2
- gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts  1

See the complete overview on Codacy

Annotations

Check failure on line 1 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L1 

Unable to resolve path to module 'mongodb'.

Check failure on line 7 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L7 

Unsafe call of an `error` type typed value.

Check failure on line 7 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L7 

Unsafe member access .getCollection on an `error` typed value.

Check failure on line 7 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L7 

Unsafe return of an error typed value.

Check failure on line 15 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L15 

Unsafe assignment of an error typed value.

Check failure on line 17 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L17 

Unsafe call of an `error` type typed value.

Check failure on line 18 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L18 

Unsafe assignment of an error typed value.

Check failure on line 18 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L18 

Unsafe member access .find on an `error` typed value.

Check failure on line 19 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L19 

Unsafe member access .sort on an `error` typed value.

Check failure on line 20 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L20 

Unsafe member access .limit on an `error` typed value.

Check failure on line 21 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L21 

Unsafe member access .toArray on an `error` typed value.

Check failure on line 24 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L24 

Unsafe construction of an any type value.

Check failure on line 27 in dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/repositories/portal/eligibility-criteria-amendments.repo.ts#L27 

Unsafe return of an error typed value.

Check failure on line 44 in dtfs-central-api/src/services/portal/facility-amendment.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.service.ts#L44 

Unsafe assignment of an error typed value.

Check failure on line 46 in dtfs-central-api/src/services/portal/facility-amendment.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.service.ts#L46 

Unsafe assignment of an error typed value.

Check failure on line 48 in dtfs-central-api/src/services/portal/facility-amendment.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.service.ts#L48 

Unsafe call of an `error` type typed value.

Check failure on line 48 in dtfs-central-api/src/services/portal/facility-amendment.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.service.ts#L48 

Unsafe member access .map on an `error` typed value.

Check failure on line 59 in dtfs-central-api/src/services/portal/facility-amendment.service.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

dtfs-central-api/src/services/portal/facility-amendment.service.ts#L59 

Unsafe assignment of an error typed value.

Check failure on line 1 in gef-ui/component-tests/partials/amendments/eligibility.component-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/component-tests/partials/amendments/eligibility.component-test.ts#L1 

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 44 in gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts#L44 

Unsafe member access .eligibilityCriteria on an `error` typed value.

Check failure on line 49 in gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts#L49 

Unsafe assignment of an error typed value.

Check failure on line 49 in gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts#L49 

Unsafe member access .eligibilityCriteria on an `error` typed value.

Check failure on line 55 in gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/eligibility-criteria/get-eligibility.ts#L55 

Unsafe assignment of an error typed value.

Check failure on line 1 in gef-ui/server/types/view-models/amendments/eligibility-view-model.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/types/view-models/amendments/eligibility-view-model.ts#L1 

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 51 in gef-ui/test-helpers/mock-amendment.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/test-helpers/mock-amendment.ts#L51 

Unsafe member access .eligibilityCriteria on an `error` typed value.
View more details on Codacy Production