Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FN-3611): browser back button behaviour after correction request submitted #4164

Merged
merged 14 commits into from
Jan 27, 2025

Conversation

Zainzzkk
Copy link
Contributor

Introduction ✏️

This PR handles the back button behaviour after the correction request is submitted. Previously a cached version of the page was loaded without calling the relevant get controller for check-the-information. This PR handles that by setting 'Cache-Control' to 'no-store' and redirecting to page-not-found if submitted already

Resolution ✔️

  • Added errorKey to be returned from get-fee-record-correction-request-review.controller/index.ts if status set to PENDING_CORRECTION
  • Added check to record-corrections/check-the-information/index.ts if errorKey is returned from api call, then to redirect to page-not-found
  • Added helper to check if errorKey is set to INVALID
  • Added helper to check that responseBody is correct type
  • Added middleware to set Cache-Control to no-store
  • Added middleware to create-record-correction-request and check-the-information get routes only
  • Updated and added tests
  • Added e2e tests

@Zainzzkk Zainzzkk added Type: Feature feature Type: Fintech For fintech related work labels Jan 22, 2025
@Zainzzkk Zainzzkk self-assigned this Jan 22, 2025
@Zainzzkk Zainzzkk merged commit 88ee288 into main Jan 27, 2025
237 of 239 checks passed
@Zainzzkk Zainzzkk deleted the feat/FN-3611 branch January 27, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature feature Type: Fintech For fintech related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants