Skip to content

feat(FN-3671): add bank correction history tab backend endpoint #4178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jan 30, 2025

Conversation

sw-mattw
Copy link
Contributor

@sw-mattw sw-mattw commented Jan 27, 2025

Introduction ✏️

Portal requires a history tab for viewing completed fee record corrections. A new API endpoint is required in central-api to provide the data that is to be rendered on this tab.

This PR introduces the backend endpoints required for this ticket, with the frontend and E2E test work to be added in subsequent pull requests under this ticket.

Resolution ✔️

  • Added new portal-api GET endpoint /banks/:bankId/utilisation-reports/completed-corrections and controller
  • Added new central-api GET endpoint (/utilisation-reports/completed-fee-record-corrections/:bankId) and controller for getting completed fee record corrections by bank ID.
  • Added new fee record correction repo method for getting completed corrections by bank ID
  • Added unit tests
  • Added API tests

Miscellaneous ➕

  • Extracted the validateRequiredCorrectionField helper function into a 'global' central-api helper instead of this belonging to a specific controller.

@sw-mattw sw-mattw merged commit 3a89512 into main Jan 30, 2025
238 of 249 checks passed
@sw-mattw sw-mattw deleted the feat/FN-3671/add-bank-correction-history-tab branch January 30, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature feature Type: Fintech For fintech related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants