-
Notifications
You must be signed in to change notification settings - Fork 5
feat(FN-3671): add bank correction history tab backend endpoint #4178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-correction-history-tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
Portal requires a history tab for viewing completed fee record corrections. A new API endpoint is required in
central-api
to provide the data that is to be rendered on this tab.This PR introduces the backend endpoints required for this ticket, with the frontend and E2E test work to be added in subsequent pull requests under this ticket.
Resolution ✔️
portal-api
GET endpoint/banks/:bankId/utilisation-reports/completed-corrections
and controllercentral-api
GET endpoint (/utilisation-reports/completed-fee-record-corrections/:bankId
) and controller for getting completed fee record corrections by bank ID.Miscellaneous ➕
validateRequiredCorrectionField
helper function into a 'global'central-api
helper instead of this belonging to a specific controller.