Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7781): add effective from date e2e tests #4189

Merged
merged 6 commits into from
Feb 4, 2025

Merge branch 'main' into feat/DTFS2-7781/add-effective-from-date-e2e-…

43b9222
Select commit
Loading
Failed to load commit list.
Merged

feat(DTFS2-7781): add effective from date e2e tests #4189

Merge branch 'main' into feat/DTFS2-7781/add-effective-from-date-e2e-…
43b9222
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Feb 3, 2025 in 0s

52 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 52
           

Complexity increasing per file
==============================
- e2e-tests/gef/cypress/e2e/pages/amendments/effective-date.js  1
- e2e-tests/ukef/cypress/e2e/journeys/portal/amendments/pages/effective-date.spec.js  1
         

Clones added
============
- e2e-tests/gef/cypress/e2e/pages/amendments/effective-date.js  1
- gef-ui/component-tests/partials/amendments/effective-date.component-test.ts  5
- gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts  1
- gef-ui/server/controllers/amendments/effective-date/post-effective-date.ts  2
- gef-ui/api-tests/amendments/effective-date.post.api-test.ts  24
- gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts  26
- gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts  25
- e2e-tests/ukef/cypress/e2e/journeys/portal/amendments/pages/effective-date.spec.js  18

See the complete overview on Codacy

Annotations

Check failure on line 58 in gef-ui/api-tests/amendments/effective-date.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/effective-date.post.api-test.ts#L58 

Unsafe call of an `error` type typed value.

Check failure on line 77 in gef-ui/api-tests/amendments/effective-date.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/effective-date.post.api-test.ts#L77 

Unsafe assignment of an error typed value.

Check failure on line 77 in gef-ui/api-tests/amendments/effective-date.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/effective-date.post.api-test.ts#L77 

Unsafe call of an `error` type typed value.

Check failure on line 78 in gef-ui/api-tests/amendments/effective-date.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/effective-date.post.api-test.ts#L78 

Unsafe assignment of an error typed value.

Check failure on line 78 in gef-ui/api-tests/amendments/effective-date.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/effective-date.post.api-test.ts#L78 

Unsafe call of an `error` type typed value.

Check failure on line 69 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts#L69 

Unsafe argument of type `any` assigned to a parameter of type `Response<any, Record<string, any>>`.

Check failure on line 147 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts#L147 

Unsafe assignment of an error typed value.

Check failure on line 147 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts#L147 

Unsafe call of an `error` type typed value.

Check failure on line 149 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.test.ts#L149 

Unsafe assignment of an error typed value.

Check failure on line 46 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts#L46 

Unsafe assignment of an error typed value.

Check failure on line 47 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts#L47 

Unsafe call of an `error` type typed value.

Check failure on line 47 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts#L47 

Unsafe member access .effectiveDate on an `error` typed value.

Check failure on line 55 in gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/get-effective-date.ts#L55 

Unsafe assignment of an error typed value.

Check failure on line 51 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L51 

Unsafe call of an `error` type typed value.

Check failure on line 51 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L51 

Unsafe member access .createMocks on an `error` typed value.

Check failure on line 64 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L64 

Unsafe member access .day on an `error` typed value.

Check failure on line 65 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L65 

Unsafe assignment of an error typed value.

Check failure on line 66 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L66 

Unsafe assignment of an error typed value.

Check failure on line 86 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L86 

Unsafe call of an `error` type typed value.

Check failure on line 163 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L163 

Unsafe call of an `error` type typed value.

Check failure on line 163 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L163 

Unsafe member access ._getRenderView on an `error` typed value.

Check failure on line 169 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L169 

Unsafe call of an `error` type typed value.

Check failure on line 177 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.test.ts#L177 

Unsafe assignment of an error typed value.

Check failure on line 34 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.ts#L34 

Unsafe assignment of an error typed value.

Check failure on line 36 in gef-ui/server/controllers/amendments/effective-date/post-effective-date.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/effective-date/post-effective-date.ts#L36 

Unsafe member access .body on an `error` typed value.
View more details on Codacy Production