Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DTFS2-7733): post cancel amendment #4199

Merged
merged 27 commits into from
Feb 17, 2025

Merge branch 'main' into feat/DTFS2-7733/post-cancel-amendment

5854cac
Select commit
Loading
Failed to load commit list.
Merged

feat(DTFS2-7733): post cancel amendment #4199

Merge branch 'main' into feat/DTFS2-7733/post-cancel-amendment
5854cac
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Feb 14, 2025 in 0s

44 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 44
           

Complexity increasing per file
==============================
- gef-ui/api-tests/amendments/cancel-portal-facility-amendment.get.api-test.ts  1
- gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts  1
- gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts  1
- gef-ui/server/controllers/amendments/cancel-amendment/get-cancel-portal-facility-amendment.test.ts  1
- gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.ts  2
         

Clones added
============
- gef-ui/api-tests/amendments/cancel-portal-facility-amendment.get.api-test.ts  5
- gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts  11
- gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts  2
- gef-ui/server/controllers/amendments/cancel-amendment/get-cancel-portal-facility-amendment.test.ts  4

See the complete overview on Codacy

Annotations

Check failure on line 4 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L4 

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 36 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L36 

Unsafe member access .MAKER on an `error` typed value.

Check failure on line 92 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L92 

Unsafe assignment of an error typed value.

Check failure on line 93 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L93 

Unsafe member access .status on an `error` typed value.

Check failure on line 95 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L95 

Unsafe member access .body on an `error` typed value.

Check failure on line 97 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L97 

Unsafe assignment of an error typed value.

Check failure on line 97 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L97 

Unsafe member access .INVALID_MONGO_ID_PATH_PARAMETER on an `error` typed value.

Check failure on line 142 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L142 

Unsafe member access .headers on an `error` typed value.

Check failure on line 154 in gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/api-tests/amendments/cancel-portal-facility-amendment.post.api-test.ts#L154 

Unsafe member access .status on an `error` typed value.

Check failure on line 5 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L5 

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 6 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L6 

Unable to resolve path to module '@ukef/dtfs2-common'.

Check failure on line 19 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L19 

Unsafe assignment of an error typed value.

Check failure on line 19 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L19 

Unsafe call of an `error` type typed value.

Check failure on line 23 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L23 

Unsafe call of an `error` type typed value.

Check failure on line 23 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L23 

Unsafe return of an error typed value.

Check failure on line 30 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L30 

Unsafe assignment of an error typed value.

Check failure on line 32 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L32 

Unsafe assignment of an error typed value.

Check failure on line 48 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L48 

Unsafe assignment of an error typed value.

Check failure on line 51 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L51 

Unsafe argument of type `any` assigned to a parameter of type `Response<any, Record<string, any>>`.

Check failure on line 81 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.test.ts#L81 

Unsafe call of an `error` type typed value.

Check failure on line 18 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.ts#L18 

Unsafe member access .params on an `error` typed value.

Check failure on line 19 in gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/controllers/amendments/cancel-amendment/post-cancel-portal-facility-amendment.ts#L19 

Unsafe member access .session on an `error` typed value.

Check failure on line 78 in gef-ui/server/routes/facilities/amendments/index.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/routes/facilities/amendments/index.ts#L78 

Unsafe call of an `error` type typed value.

Check failure on line 79 in gef-ui/server/routes/facilities/amendments/index.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/routes/facilities/amendments/index.ts#L79 

Unsafe call of an `error` type typed value.

Check failure on line 80 in gef-ui/server/routes/facilities/amendments/index.ts

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

gef-ui/server/routes/facilities/amendments/index.ts#L80 

Unsafe call of an `error` type typed value.
View more details on Codacy Production