Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DTFS2-7494): hide change button when amendment underway #4204

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(DTFS2-7494): hide change button when amendment underway #4204

wants to merge 4 commits into from

Conversation

BethThomas141
Copy link
Contributor

Introduction ✏️

  • This adds the endpoint to fetch all the amendments across a deal to portal-api and gef-ui, as well as hides the 'make a change' button on the front end when an amendment is underway.

Resolution ✔️

  • add get amendments for deal endpoint to portal-api and gef-ui
  • call the endpoint on the frontend and hide the make a change button if an amendment exists on the deal with an underway status

Miscellaneous ➕

  • I'll add E2E tests as a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkontogianni rkontogianni rkontogianni approved these changes

@MarRobSoftwire MarRobSoftwire MarRobSoftwire left review comments

Assignees

@BethThomas141 BethThomas141

Labels
Type: Feature feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BethThomas141 @MarRobSoftwire @rkontogianni