Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FN-3163): allow non gef deals #4209

Merged
merged 7 commits into from
Feb 10, 2025
Merged

feat(FN-3163): allow non gef deals #4209

merged 7 commits into from
Feb 10, 2025
+68 −22

Conversation

natdeanlewissoftwire
Copy link
Contributor

@natdeanlewissoftwire natdeanlewissoftwire commented Feb 6, 2025 •
edited
Loading

Introduction ✏️

From QA testing it was recognised that it would be good to allow non-GEF deals to automatically create customers in Salesforce (as well as GEF deals which already have this behaviour implemented). The only blocker to this is that Probability of Default needs to be optional as non-GEF exporters don't have a Probability of Default entered.

Resolution ✔️

Make Probability of Default optional.

Misc

Remove a duplicated env var from .env.sample

@natdeanlewissoftwire natdeanlewissoftwire changed the title feat: make probability of default optional feat(FN-3163): allow-non-gef-deals Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-markan abhi-markan abhi-markan approved these changes

Assignees

@natdeanlewissoftwire natdeanlewissoftwire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natdeanlewissoftwire @abhi-markan