Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FN-3615): add links, e2e tests, and refactor pdc record correction log #4213

Merged
merged 15 commits into from
Feb 12, 2025

Conversation

sw-mattw
Copy link
Contributor

Introduction ✏️

The PDC record correction log table needs to link to the new "correction details" screen implemented in a prior PR (#4206). Additionally, a back link needs adding to this details page. E2E tests are also required.

Resolution ✔️

  • Added backlink support to the details screen
    • Involved passing the report ID back in the 'log details' response
  • Added link from correction log table to the details screen
  • Added e2e tests for the details screen
  • Added new component test cases to test the two new links

Miscellaneous ➕

  • Add missing component tests for the record correction table
  • Refactor component tests for the record correction log details screen
  • Move email formatting to TFM UI as we want one line per email for consistency (formattedBankTeamEmails -> bankTeamEmails)

@sw-mattw sw-mattw added Type: Feature feature Type: Fintech For fintech related work labels Feb 10, 2025
@sw-mattw sw-mattw self-assigned this Feb 10, 2025
@sw-mattw sw-mattw merged commit b2f77cc into main Feb 12, 2025
238 of 239 checks passed
@sw-mattw sw-mattw deleted the feat/FN-3615/link-to-page-and-add-e2e-tests branch February 12, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature feature Type: Fintech For fintech related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants