Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FN-3843): fix record correction "bank commentary" being stored as an empty string #4215

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

sw-mattw
Copy link
Contributor

@sw-mattw sw-mattw commented Feb 10, 2025

Introduction ✏️

When 'Other' is not one of the record correction request reasons, the bank commentary field is optional.

The existing parsing trimmed any whitespace, but stored an empty string value if no input was provided (instead of undefined). This led to some other pages (e.g., "check the information" and the "record correction log") not rendering a hyphen when the bank commentary field was left blank (instead this rendered nothing which isn't consistent with our other tables).

Resolution ✔️

  • Ensure that an empty "additional information" input value is stored as undefined
  • Add additional tests

Screenshot showing the first row, which doesn't have 'Other' as a reason, rendering a hyphen ("-") in the "correction notes" column as the "additional information" input was left empty when this correction was submitted:

row with hyphen

Miscellaneous ➕

N/A

@sw-mattw sw-mattw added Type: Bug Something isn't working Type: Fintech For fintech related work labels Feb 10, 2025
@sw-mattw sw-mattw self-assigned this Feb 10, 2025
@sw-mattw sw-mattw marked this pull request as ready for review February 10, 2025 18:20
@sw-mattw sw-mattw changed the title fix(FN-3843): fix bank commentary empty string fix(FN-3843): fix record correction "bank commentary" being stored as an empty string Feb 10, 2025
@sw-mattw sw-mattw merged commit 63f57a2 into main Feb 12, 2025
238 of 239 checks passed
@sw-mattw sw-mattw deleted the fix/FN-3843/fix-bank-commentary-empty-string branch February 12, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Fintech For fintech related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants