-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FN-3843): fix record correction "bank commentary" being stored as an empty string #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-markan
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
When 'Other' is not one of the record correction request reasons, the bank commentary field is optional.
The existing parsing trimmed any whitespace, but stored an empty string value if no input was provided (instead of undefined). This led to some other pages (e.g., "check the information" and the "record correction log") not rendering a hyphen when the bank commentary field was left blank (instead this rendered nothing which isn't consistent with our other tables).
Resolution ✔️
undefined
Screenshot showing the first row, which doesn't have 'Other' as a reason, rendering a hyphen ("-") in the "correction notes" column as the "additional information" input was left empty when this correction was submitted:
Miscellaneous ➕
N/A