Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FN-3813): remove adjustment columns from keying sheet #4220

Merged
merged 19 commits into from
Feb 14, 2025

Conversation

RLavender98
Copy link
Contributor

@RLavender98 RLavender98 commented Feb 12, 2025

Introduction ✏️

The adjustment columns from the keying sheet are not actually being used by users in their current state and there is not a plan to make them work, so we should simply remove them.

Resolution ✔️

  • Remove adjustment columns, fixed fee and principal balance, from the keying sheet template.
  • Drop facility utilisation data table (table used to track utilisation and fixed fee so that the adjustments can be calculated)
  • Remove initialisation of facility utilisation data on report upload (as we no longer need to track this)
  • Remove calculation of keying sheet adjustments from generate keying data controller.
  • Drop fixed fee adjustment and principal balance adjustment database columns from FeeRecord table.
  • Remove fixed fee adjustment and principal balance adjustment from api response when fetching data to populate keying sheet table.
  • Remove removed entities from sql db helpers and mock builders.
  • Remove facility utilisation data entities from sql-db-seeder
  • Fetch facility ids to seed tfm facilities from FeeRecord table instead of removed FacilityUtilisationData table in create-keying-sheet-tfm-facilities script
  • Remove migrate-acbs-utilisation-data-to-tfm script from utils since it is no longer relevant (used to populate FacilityUtilisationData for existing facilities for banks opting in to the service for the first time)

Screenshots 🖼️

Screenshot 2025-02-12 at 15 48 06

@RLavender98 RLavender98 merged commit d4c49b9 into main Feb 14, 2025
238 checks passed
@RLavender98 RLavender98 deleted the feat/FN-3813/remove-adjustments-from-keying-sheet branch February 14, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants