Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DTFS2-7797): add check your answers e2e tests #4222

Merged
merged 6 commits into from
Feb 13, 2025
Merged

feat(DTFS2-7797): add check your answers e2e tests #4222

merged 6 commits into from
Feb 13, 2025

Conversation

MarRobSoftwire
Copy link
Contributor

@MarRobSoftwire MarRobSoftwire commented Feb 12, 2025 •
edited
Loading

Introduction ✏️

Updates e2e tests to cover check your answers and submitted for checking pages

Resolution ✔️

  • Add Check your answers and Submitted pages to amendments journey e2e tests
  • Add Check your answers page e2e test

Miscellaneous ➕

  • Update component tests with changed data-cy

@MarRobSoftwire MarRobSoftwire force-pushed the feat/DTFS2-7797/add-check-your-answers-e2e-tests branch from 74bd45e to 9f5ca29 Compare February 12, 2025 16:45
@MarRobSoftwire MarRobSoftwire added the Test Unit, API, E2E and Test coverage documentation label Feb 12, 2025
@MarRobSoftwire MarRobSoftwire marked this pull request as ready for review February 13, 2025 09:22
BethThomas141
BethThomas141 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@BethThomas141 BethThomas141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for including all these, good checks on the check your answer page on the journey flows👍

@MarRobSoftwire MarRobSoftwire merged commit 08ec1fa into main Feb 13, 2025
238 of 239 checks passed
@MarRobSoftwire MarRobSoftwire deleted the feat/DTFS2-7797/add-check-your-answers-e2e-tests branch February 13, 2025 10:06
@abhi-markan abhi-markan mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethThomas141 BethThomas141 BethThomas141 approved these changes

@rkontogianni rkontogianni rkontogianni approved these changes

@abhi-markan abhi-markan Awaiting requested review from abhi-markan

Assignees

@MarRobSoftwire MarRobSoftwire

Labels
Test Unit, API, E2E and Test coverage documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarRobSoftwire @BethThomas141 @rkontogianni