chore(e2e): address todo comments

UK-Export-Finance · Jan 13, 2025 · 9a2ae96 · 9a2ae96
1 parent 95ab7e1
commit 9a2ae96
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 16 deletions.
diff --git a/...ance/cypress/e2e/journeys/policy/broker-manual-address/broker-manual-address-page.spec.js b/...ance/cypress/e2e/journeys/policy/broker-manual-address/broker-manual-address-page.spec.js
@@ -15,7 +15,7 @@ const {
 
 const {
   ROOT,
-  POLICY: { BROKER_MANUAL_ADDRESS_ROOT, LOSS_PAYEE_ROOT },
+  POLICY: { BROKER_DETAILS_ROOT, BROKER_MANUAL_ADDRESS_ROOT, LOSS_PAYEE_ROOT },
 } = INSURANCE_ROUTES;
 
 const { BROKER_MANUAL_ADDRESS: FIELD_STRINGS } = FIELDS;
@@ -34,14 +34,11 @@ context(
         referenceNumber = refNumber;
 
         // go to the page we want to test.
-        cy.completeAndSubmitPolicyForms({ stopSubmittingAfter: 'brokerDetails', usingBroker: true });
+        cy.completeAndSubmitPolicyForms({ stopSubmittingAfter: 'brokerDetails', usingBroker: true, isBasedInUk: false });
 
         url = `${baseUrl}${ROOT}/${referenceNumber}${BROKER_MANUAL_ADDRESS_ROOT}`;
         lossPayeeUrl = `${baseUrl}${ROOT}/${referenceNumber}${LOSS_PAYEE_ROOT}`;
 
-        // TODO: EMS-3973 - remove this
-        cy.navigateToUrl(url);
-
         cy.assertUrl(url);
       });
     });
@@ -58,7 +55,7 @@ context(
       cy.corePageChecks({
         pageTitle: CONTENT_STRINGS.PAGE_TITLE,
         currentHref: `${ROOT}/${referenceNumber}${BROKER_MANUAL_ADDRESS_ROOT}`,
-        backLink: `${ROOT}/${referenceNumber}${BROKER_MANUAL_ADDRESS_ROOT}#`,
+        backLink: `${ROOT}/${referenceNumber}${BROKER_DETAILS_ROOT}`,
       });
     });
 

diff --git a/e2e-tests/insurance/cypress/e2e/journeys/policy/broker-manual-address/save-and-back.spec.js b/e2e-tests/insurance/cypress/e2e/journeys/policy/broker-manual-address/save-and-back.spec.js
@@ -23,13 +23,10 @@ context('Insurance - Policy - Broker manual address page - Save and back', () =>
       referenceNumber = refNumber;
 
       // go to the page we want to test.
-      cy.completeAndSubmitPolicyForms({ stopSubmittingAfter: 'brokerDetails', usingBroker: true });
+      cy.completeAndSubmitPolicyForms({ stopSubmittingAfter: 'brokerDetails', usingBroker: true, isBasedInUk: false });
 
       url = `${baseUrl}${ROOT}/${referenceNumber}${BROKER_MANUAL_ADDRESS_ROOT}`;
 
-      // TODO: EMS-3973 - remove this
-      cy.navigateToUrl(url);
-
       cy.assertUrl(url);
     });
   });
@@ -76,8 +73,12 @@ context('Insurance - Policy - Broker manual address page - Save and back', () =>
     });
 
     it('should have the originally submitted answer selected when going back to the page after submission', () => {
-      // TODO: EMS-3973 - remove this, use cy.clickSubmitButtonMultipleTimes instead.
-      cy.navigateToUrl(url);
+      cy.navigateToAllSectionsUrl(referenceNumber);
+
+      cy.startInsurancePolicySection({});
+
+      // go through 8 policy forms.
+      cy.clickSubmitButtonMultipleTimes({ count: 8 });
 
       cy.checkTextareaValue({
         fieldId: FIELD_ID,

diff --git a/...journeys/policy/broker-manual-address/validation/broker-manual-address-validation.spec.js b/...journeys/policy/broker-manual-address/validation/broker-manual-address-validation.spec.js
@@ -30,13 +30,10 @@ context('Insurance - Policy - Broker manual address page - validation', () => {
       referenceNumber = refNumber;
 
       // go to the page we want to test.
-      cy.completeAndSubmitPolicyForms({ stopSubmittingAfter: 'brokerDetails', usingBroker: true });
+      cy.completeAndSubmitPolicyForms({ stopSubmittingAfter: 'brokerDetails', usingBroker: true, isBasedInUk: false });
 
       url = `${baseUrl}${ROOT}/${referenceNumber}${BROKER_MANUAL_ADDRESS_ROOT}`;
 
-      // TODO: EMS-3973 - remove this
-      cy.navigateToUrl(url);
-
       cy.assertUrl(url);
     });
   });