-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-4015): application submission - xlsx - uk broker address #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttbarnes
added
enhancement
New feature or request
tech
Technical debt/improvements
labels
Jan 9, 2025
abhi-markan
approved these changes
Jan 13, 2025
ttbarnes
merged commit Jan 13, 2025
6a0f1bf
into
main-broker-address-lookup
185 of 186 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the application submission's XLSX mapping to handle UK broker addresses.
Previously, the XLSX would only render a single
FULL_ADDRESS
string. Now, UK addresses are supported which contain multiple fields. Therefore we need to map these fields/substrings into a single string.Resolution ✔️
mapBrokerAddress
helper function.mapBrokerAddressBasedInTheUk
helper function.mapBroker
to consumemapBrokerAddress
.isEmptyString
helper function to the API.