Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-4015): application submission - xlsx - uk broker address #3468

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Jan 9, 2025

Introduction ✏️

This PR updates the application submission's XLSX mapping to handle UK broker addresses.

Previously, the XLSX would only render a single FULL_ADDRESS string. Now, UK addresses are supported which contain multiple fields. Therefore we need to map these fields/substrings into a single string.

Resolution ✔️

  • Create new mapBrokerAddress helper function.
  • Create new mapBrokerAddressBasedInTheUk helper function.
  • Update mapBroker to consume mapBrokerAddress.
  • Add isEmptyString helper function to the API.
  • Update test mocks, types and mocks.

@ttbarnes ttbarnes added enhancement New feature or request tech Technical debt/improvements labels Jan 9, 2025
@ttbarnes ttbarnes self-assigned this Jan 9, 2025
@ttbarnes ttbarnes merged commit 6a0f1bf into main-broker-address-lookup Jan 13, 2025
185 of 186 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-4015 branch January 13, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants