-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-4054): broker addresses - single address redirection #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-markan
requested changes
Jan 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments to address please.
src/ui/server/helpers/generate-broker-address-inset-text-html/index.test.ts
Show resolved
Hide resolved
abhi-markan
approved these changes
Jan 20, 2025
ttbarnes
merged commit Jan 20, 2025
f32ebd8
into
main-broker-address-lookup
187 of 188 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the broker address lookup functionality so that if a broker is based in the UK and only one address is returned from Ordnance Survey, the user is redirected (from
BROKER_DETAILS
) toBROKER_CONFIRM_ADDRESS
, instead ofBROKER_ADDRESSES
.Otherwise, the user would be selected only one available option from the
BROKER_ADDRESSES
form.This PR also updates the "confirm broker address" page to render an address appropriately via a helper function, depending on if the address was entered manually, or obtained via Ordnance Survey.
Resolution ✔️
BROKER_ADDRESSES
GET controller to map/save data and redirect toBROKER_CONFIRM_ADDRESS
if only one address is returned from the API.getChosenOrdnanceSurveyAddress
togetOrdnanceSurveyAddressById
.getChosenOrdnanceSurveyAddressByIndex
helper function.generateBrokerAddressInsetTextHtml
helper function.cy.clickZeroAddressesEnterManuallyLink();
.Miscellaneous ➕
ADDRESS_LOOKUP_INPUT_EXAMPLES
.