-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EMS-4100): country risk logic - quote - no online support #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttbarnes
added
bug
Something isn't working
documentation
Improvements or additions to documentation
tech
Technical debt/improvements
chore
Chore
fix
Fixes an existing issue
labels
Jan 14, 2025
abhi-markan
requested changes
Jan 14, 2025
src/ui/server/controllers/quote/talk-to-an-export-finance-manager/index.test.ts
Show resolved
Hide resolved
abhi-markan
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
chore
Chore
documentation
Improvements or additions to documentation
fix
Fixes an existing issue
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR fixes an issue where in the quote tool - if a country has no online support, it should redirect to a "Talk to EFM" exit page, instead of a "Get a quote by email" exit page.
Resolution ✔️
TALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT
constants and content strings into a shared file, since this is now used in both the quote tool and application eligibility.BUYER_COUNTRY
POST controller to redirect toTALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT
if no online support is available.TALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT
quote tool GET route and controller.requiredQuoteEligibilityDataProvided
middleware to includeTALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT
.Miscellaneous ➕
NEED_TO_START_AGAIN
E2E constant toNEED_TO_START_AGAIN_EXIT
, to be consistent.