Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-4100): country risk logic - quote - no online support #3476

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR fixes an issue where in the quote tool - if a country has no online support, it should redirect to a "Talk to EFM" exit page, instead of a "Get a quote by email" exit page.

Resolution ✔️

  • Move appropriate TALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT constants and content strings into a shared file, since this is now used in both the quote tool and application eligibility.
  • Update E2E country fixtures to include more "no online support" countries for the quote tool.
  • Add/update E2E tests, add more "no online support" coverage.
  • Update the quote tool's BUYER_COUNTRY POST controller to redirect to TALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT if no online support is available.
  • Create new TALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT quote tool GET route and controller.
  • Update requiredQuoteEligibilityDataProvided middleware to include TALK_TO_AN_EXPORT_FINANCE_MANAGER_EXIT.

Miscellaneous ➕

  • Rename all instances of "Buyer body" to "Type of buyer". This URL was changed a long time ago - the "buyer body" instances caused some confusion.
  • Rename NEED_TO_START_AGAIN E2E constant to NEED_TO_START_AGAIN_EXIT, to be consistent.
  • Minor documentation improvements.

@ttbarnes ttbarnes added bug Something isn't working documentation Improvements or additions to documentation tech Technical debt/improvements chore Chore fix Fixes an existing issue labels Jan 14, 2025
@ttbarnes ttbarnes self-assigned this Jan 14, 2025
@abhi-markan abhi-markan merged commit 306fd7b into main Jan 15, 2025
183 checks passed
@abhi-markan abhi-markan deleted the fix/EMS-4100-quote branch January 15, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chore documentation Improvements or additions to documentation fix Fixes an existing issue tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants