Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EMS-4130): broker zero addresses url, minor tech improvements #3486

Merged
merged 7 commits into from
Jan 18, 2025

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR fixes an issues where the UI's "Broker - zero addresses" URL was incorrect.

Also introduces some technical alignments regarding tests and documentation.

Resolution ✔️

  • EMS-4130: Update BROKER_ZERO_ADDRESSES_ROOT constant.
  • EMS-4131: Replace instances of e.g test('it should ... with it('should ...
  • Update some UI GQL call error handlings that incorrectly had "network error" in some console errors.
  • Update some UI validation functions to use formBody param, instead of responseBody.
  • Simplify some UI validation functions documentation.

Miscellaneous ➕

  • Fix some typos.
  • Replace instances of "should display" with "should render".
  • Minor task function documentation improvements.

@ttbarnes ttbarnes added bug Something isn't working documentation Improvements or additions to documentation tech Technical debt/improvements chore Chore fix Fixes an existing issue labels Jan 16, 2025
@ttbarnes ttbarnes self-assigned this Jan 16, 2025
@abhi-markan abhi-markan merged commit b8cd084 into main-broker-address-lookup Jan 18, 2025
187 of 188 checks passed
@abhi-markan abhi-markan deleted the fix/EMS-4130 branch January 18, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Chore documentation Improvements or additions to documentation fix Fixes an existing issue tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants