chore(EMS-4132): broker - confirm address - data checks #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-markan
requested changes
Jan 18, 2025
| @@ -32,8 +32,6 @@ context('Insurance - Policy - Broker addresses page - Visit directly without com | |||
| }); | |||
|
|
|||
| it(`should redirect to ${BROKER_DETAILS_ROOT}`, () => { | |||
| cy.navigateToUrl(url); | |||
There was a problem hiding this comment.
If the test is not navigating, is it safe for me to assume that the test is already on the brokerDetailsUrl?
| beforeEach(() => { | ||
| cy.saveSession(); | ||
|
|
||
| cy.navigateToUrl(url); |
There was a problem hiding this comment.
If we are navigating to url then why are we asserting a different url brokerDetailsUrl?
| }); | ||
|
|
||
| describe(`when application.broker has ${FIELD_ID}, no ${POSTCODE} or ${BUILDING_NUMBER_OR_NAME}`, () => { | ||
| beforeEach(() => { |
There was a problem hiding this comment.
Can we add an assertion when there is no BUILDING_NUMBER_OR_NAME but has FIELD_ID and POSTCODE please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the "confirm broker address" GET controller so that if a user manually navigates to this route when no address data is available, they will be redirected to the "Broker details" form, where such data can be provided.
Resolution ✔️