-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-4141): broker address lookup - manual entry #3494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttbarnes
added
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
chore
Chore
labels
Jan 23, 2025
abhi-markan
requested changes
Jan 24, 2025
src/ui/server/helpers/generate-enter-broker-address-manually-url/index.ts
Show resolved
Hide resolved
abhi-markan
approved these changes
Jan 24, 2025
ttbarnes
merged commit Jan 24, 2025
4dee04f
into
main-broker-address-lookup
186 of 188 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the broker address lookup functionality to allow a user to enter an address manually, when the broker is based in the UK, and/or the address lookup results are not as a user expects.
Previously, the logic was:
But we now allow a user to enter a manual address if a broker is based in the UK.
Resolution ✔️
E2E
provideBrokerAddressManually
flag/param.cy.assertEnterAddressManuallyLink
to consume aexpectedText
param.clickEnterAddressManuallyLink
link, cypress command.API
mapBrokerAddress
XLSX mapping function to return a value ofFULL_ADDRESS
ormapBrokerAddressBasedInTheUk
, regardless ofIS_BASED_IN_UK
.UI
brokerFullAddress
param.getBrokerTasks
logic.generateEnterBrokerAddressManuallyUrl
.BROKER_ADDRESSES
andBROKER_CONFIRM_ADDRESS
GET controllers to consumegenerateEnterBrokerAddressManuallyUrl
.mapSubmittedData
function to to wipe address lookup fields ifIS_BASED_IN_UK
is true andFULL_ADDRESS
is populated.flattenApplicationData
to only return address lookup fields ifFULL_ADDRESS
is not populated.brokerAddressField
mapping function to return aFULL_ADDRESS
field/row, if populated.Miscellaneous ➕