Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(EMS-4062-4099): logging, unit test improvements #3506

Open
wants to merge 7 commits into
base: main-broker-address-lookup
Choose a base branch
from
Open

chore(EMS-4062-4099): logging, unit test improvements #3506

wants to merge 7 commits into from

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

  • ALLOWED_GRAPHQL_RESOLVERS did not have any unit test coverage.
  • Some API test helpers had undescriptive console errors.
  • UI mapAndSave functions could benefit from having a console.error, if no save response is returned.

Resolution ✔️

  • Add some unit tests for ALLOWED_GRAPHQL_RESOLVERS.
  • Update API test helper console errors.
  • Add console.error to UI mapAndSave function's saveResponse calls.

Miscellaneous ➕

  • Wrap some API test helpers with a try/catch and Promise.all
  • Fix some typos.

@ttbarnes ttbarnes added tech Technical debt/improvements chore Chore labels Jan 28, 2025
@ttbarnes ttbarnes self-assigned this Jan 28, 2025
@ttbarnes ttbarnes requested a review from abhi-markan January 29, 2025 22:01
@ttbarnes
Copy link
Contributor Author

@abhi-markan Ready for re-review please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-markan abhi-markan Awaiting requested review from abhi-markan

Requested changes must be addressed to merge this pull request.

Assignees

@ttbarnes ttbarnes

Labels
chore Chore tech Technical debt/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttbarnes @abhi-markan