Skip to content

chore(deps): update dependency eslint-plugin-simple-import-sort to v12 #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-simple-import-sort ^10.0.0 -> ^12.0.0 age adoption passing confidence

Release Notes

lydell/eslint-plugin-simple-import-sort (eslint-plugin-simple-import-sort)

v12.0.0

Compare Source

This release removes the support for import assignments added in version 11.0.0:

  • Turns out it was broken in some cases.
  • The suggested fix went past my complexity tolerance for such an esoteric feature.
  • I also learned that they aren’t really imports, and that I don’t understand their semantics well enough to know how sorting them affects your program.

If you miss the support for import assignments, I suggest you write your own ESLint rule which moves them out of the way from the actual imports, sorting them or not.

v11.0.0

Compare Source

This release adds support for TypeScript import assignments (import A = B.C and import A = require("module")). Thanks to Szabolcs Kurdi (@​szku01) and Svyatoslav Zaytsev (@​MillerSvt)!

It’s only a breaking change if you use TypeScript import assignments, and only in the form that you need to autofix your files.

In other news, this release adds the meta plugin property in preparation for ESLint Flat Config, and avoids the deprecated context.getSourceCode() method (while still being backwards compatible).


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Contributor Author

renovate bot commented Feb 11, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @nestjs/axios@3.0.1
npm ERR! Found: reflect-metadata@0.2.1
npm ERR! node_modules/reflect-metadata
npm ERR!   reflect-metadata@"^0.2.1" from the root project
npm ERR!   reflect-metadata@"^0.2.1" from typeorm@0.3.20
npm ERR!   node_modules/typeorm
npm ERR!     typeorm@"^0.3.20" from the root project
npm ERR!     peerOptional typeorm@"*" from @nestjs/terminus@10.2.1
npm ERR!     node_modules/@nestjs/terminus
npm ERR!       @nestjs/terminus@"^10.2.1" from the root project
npm ERR!     2 more (@nestjs/typeorm, typeorm-extension)
npm ERR!   1 more (typeorm-extension)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer reflect-metadata@"^0.1.12" from @nestjs/axios@3.0.1
npm ERR! node_modules/@nestjs/axios
npm ERR!   @nestjs/axios@"^3.0.1" from the root project
npm ERR!   peerOptional @nestjs/axios@"^1.0.0 || ^2.0.0 || ^3.0.0" from @nestjs/terminus@10.2.1
npm ERR!   node_modules/@nestjs/terminus
npm ERR!     @nestjs/terminus@"^10.2.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: reflect-metadata@0.1.14
npm ERR! node_modules/reflect-metadata
npm ERR!   peer reflect-metadata@"^0.1.12" from @nestjs/axios@3.0.1
npm ERR!   node_modules/@nestjs/axios
npm ERR!     @nestjs/axios@"^3.0.1" from the root project
npm ERR!     peerOptional @nestjs/axios@"^1.0.0 || ^2.0.0 || ^3.0.0" from @nestjs/terminus@10.2.1
npm ERR!     node_modules/@nestjs/terminus
npm ERR!       @nestjs/terminus@"^10.2.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-02-11T05_12_56_739Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-02-11T05_12_56_739Z-debug-0.log

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor Author

renovate bot commented May 13, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 12.x releases. But if you manually upgrade to 12.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/major-12-all branch May 13, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant