Abzu-160537-fix snyk issue related to Path Traversal #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiviteshT
force-pushed
the
Feature/Abzu-160537-fix-pthtraversal-issue
branch
from
2a8c62e
to
87210c4
Compare
rockydevnet
reviewed
Jul 22, 2024
| @@ -96,7 +97,7 @@ public ActionResult DownloadFile(string batchId, string fileName) | |||
| } | |||
| if (!string.IsNullOrEmpty(fileName)) | |||
| { | |||
| bytes = fileShareService.GetFileData(configuration["HOME"], batchId, fileName); | |||
| bytes = fileShareService.GetFileData(configuration["HOME"], Sanitise(batchId), fileName); | |||
There was a problem hiding this comment.
Since we're (rightly) sanitising the BatchId, should we also consider the same for the filename? The filename is not allowed to include any path characters. It would be harder to provide an allowed list of characters, but we could exclude \, /, and :
There was a problem hiding this comment.
Also just realised that this is a mock, so possibly not worth doing!
rockydevnet
reviewed
Jul 22, 2024
| HttpContext.Response.Headers.Add("x-redirect-status", "true"); | ||
| } | ||
|
|
||
| return File(bytes, "application/octet-stream", fileName); | ||
| } | ||
|
|
||
| public static string Sanitise(string text) |
There was a problem hiding this comment.
This is a very generic method name for a rather specific sanitisation. Should it be called something like SanitiseBatchId? For example, it wouldn't be correct to use the current method to sanitise any other input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.