On header link redirect to / route rather than hardcoded staging site #254
Conversation
This commit is a fix for UKHSA-Internal#251. On the master site https://coronavirus.data.gov.uk/ the main header redirects to https://coronavirus-staging.data.gov.uk/ On the staging site https://coronavirus-staging.data.gov.uk/ the main header redirects to https://coronavirus.data.gov.uk/ I'm assuming this is not intentional and is a bug, and set the header link to redirect to / route, so that on whatever site this project is deployed, it will always redirect to the base index page.
|
This is actually an important one, but unfortunately, this too is now obsolete. Would be happy to approve a PR against |
How is development working on this btw, is it upstream in a private repo and only then pushed to public github? |
|
@joemclo Right now, it gets pushed to our development env for testing, and it confirmed, it will be approved for staging (not the public one), and usually sits there until the next deployment to production. Soon, I will create a v3-master which will be connected to our private staging, and then releases from v3-master would be routed to prod. |
|
Ok cool. |
This commit fixes #251.
On the master site https://coronavirus.data.gov.uk/ the main header
redirects to https://coronavirus-staging.data.gov.uk/
On the staging site https://coronavirus-staging.data.gov.uk/ the main
header redirects to https://coronavirus.data.gov.uk/
I'm assuming this is not intentional and is a bug, and set the header
link to redirect to / route, so that on whatever site this project is
deployed, it will always redirect to the base index page.
Feel free to close if this was intentional behaviour.