feat: [ASL-4566] PIL-E MVP iteration 1 - course purpose HE or Training #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/model-summary/index.jsx
Outdated
Comment on lines
26
to
29
| {property === APPLICANT_TRAINING_USE_AT_WORK || property === APPLICANT_LEARNING_USE ? | ||
| <dt><Snippet {...snippetProps}>{`fields.${property}.checkAnswerLabel`}</Snippet></dt> : | ||
| <dt><Snippet {...snippetProps}>{`fields.${property}.label`}</Snippet></dt>} | ||
| <dd> |
There was a problem hiding this comment.
This should not have overrides for specific fields as that is hard to follow. Instead checkAnswerLabel should be a generic property. The Snippet component has a fallback for this use case (snippet/index.jsx)
Suggested change
| {property === APPLICANT_TRAINING_USE_AT_WORK || property === APPLICANT_LEARNING_USE ? | |
| <dt><Snippet {...snippetProps}>{`fields.${property}.checkAnswerLabel`}</Snippet></dt> : | |
| <dt><Snippet {...snippetProps}>{`fields.${property}.label`}</Snippet></dt>} | |
| <dd> | |
| <dt> | |
| <Snippet {...snippetProps} fallback={`fields.${property}.label`}> | |
| {`fields.${property}.checkAnswerLabel`} | |
| </Snippet> | |
| </dt> : | |
| <dd> |
There was a problem hiding this comment.
that doesn't work. I only want different label in 2 places and in every other place I want other label. I will call you to discuss!
There was a problem hiding this comment.
thanks for your help @jeff-horton-ho-sas .
jeff-horton-ho-sas
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.