Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSB-1444] Fix error on first render, update copy #351

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

jeff-horton-ho-sas
Copy link
Contributor

  • Don't try to render a deadline without a date set
  • Use formatDate so that invalid dates don't cause a render error
  • Update copy to singular/plural variants

- Don't try to render a deadline without a date set
- Use formatDate so that invalid dates don't cause a render error
- Update copy to singular/plural variants
@jeff-horton-ho-sas jeff-horton-ho-sas requested a review from a team November 6, 2024 18:20
@jeff-horton-ho-sas jeff-horton-ho-sas self-assigned this Nov 6, 2024
- Don't try to render a deadline without a date set
- Use formatDate so that invalid dates don't cause a render error
- Update copy to singular/plural variants
@github-actions github-actions bot force-pushed the ASSB-1444--update-condition-input-copy branch from 944da7a to e490bae Compare November 6, 2024 18:21
@github-actions github-actions bot force-pushed the ASSB-1444--update-condition-input-copy branch from 595c671 to d0b0075 Compare November 6, 2024 18:38
…t-copy' into ASSB-1444--update-condition-input-copy

# Conflicts:
#	.github/workflows/semver-check-increment.yml
Copy link

@mohomeoffice mohomeoffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay to me

@jeff-horton-ho-sas jeff-horton-ho-sas merged commit cd95668 into main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants