N-14 [Oval] Possible Duplicate Event Emission (#26)

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
UMAprotocol · Jun 18, 2024 · 6f53172 · 6f53172
1 parent 5624e60
commit 6f53172
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/controllers/BaseController.sol b/src/controllers/BaseController.sol
@@ -23,6 +23,8 @@ abstract contract BaseController is Ownable, Oval {
      * @param allowed The unlocker status to set.
      */
     function setUnlocker(address unlocker, bool allowed) public onlyOwner {
+        require(unlockers[unlocker] != allowed, "Unlocker not changed");
+
         unlockers[unlocker] = allowed;
 
         emit UnlockerSet(unlocker, allowed);

diff --git a/src/controllers/MutableUnlockersController.sol b/src/controllers/MutableUnlockersController.sol
@@ -39,6 +39,8 @@ abstract contract MutableUnlockersController is Ownable, Oval {
      * @param allowed The unlocker status to set.
      */
     function setUnlocker(address unlocker, bool allowed) public onlyOwner {
+        require(unlockers[unlocker] != allowed, "Unlocker not changed");
+
         unlockers[unlocker] = allowed;
 
         emit UnlockerSet(unlocker, allowed);