fix[oval-audit-n-06]: State Variable Visibility Not Explicitly Declared

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
UMAprotocol · Jun 17, 2024 · 9977256 · 9977256
1 parent 297ab25
commit 9977256
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/factories/StandardCoinbaseFactory.sol b/src/factories/StandardCoinbaseFactory.sol
@@ -37,7 +37,7 @@ contract OvalCoinbase is MutableUnlockersController, CoinbaseSourceAdapter, Chai
  * mutability choices are desired.
  */
 contract StandardCoinbaseFactory is Ownable, BaseFactory {
-    IAggregatorV3SourceCoinbase immutable SOURCE;
+    IAggregatorV3SourceCoinbase public immutable SOURCE;
 
     constructor(IAggregatorV3SourceCoinbase _source, uint256 _maxTraversal, address[] memory _defaultUnlockers)
         BaseFactory(_maxTraversal, _defaultUnlockers)

diff --git a/src/factories/StandardPythFactory.sol b/src/factories/StandardPythFactory.sol
@@ -38,7 +38,7 @@ contract OvalPyth is MutableUnlockersController, PythSourceAdapter, ChainlinkDes
  * needed if different mutability or interface choices are desired.
  */
 contract StandardPythFactory is Ownable, BaseFactory {
-    IPyth immutable pyth;
+    IPyth public immutable pyth;
 
     constructor(IPyth _pyth, uint256 _maxTraversal, address[] memory _defaultUnlockers)
         BaseFactory(_maxTraversal, _defaultUnlockers)

diff --git a/src/oracles/CoinbaseOracle.sol b/src/oracles/CoinbaseOracle.sol
@@ -8,7 +8,7 @@ import {IAggregatorV3SourceCoinbase} from "../interfaces/coinbase/IAggregatorV3S
  * @notice A smart contract that serves as an oracle for price data reported by a designated reporter.
  */
 contract CoinbaseOracle is IAggregatorV3SourceCoinbase {
-    address immutable reporter;
+    address public immutable reporter;
 
     uint8 public immutable decimals;