Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L-05 [Oval] PermissionProxy.execute Will Fail if Non-Zero value Is Provided #20

Conversation

Reinis-FRP
Copy link
Collaborator

Addresses audit issue: L-05 [Oval] PermissionProxy.execute Will Fail if Non-Zero value Is Provided

The PermissionProxy contract is intended to be used as a proxy for calls that unlock new
prices reported as a part of the MEV-share auction flow. It allows multiple different accounts to
unlock new prices by performing calls to the controllers on their behalf. Calls may only be
performed by authorized accounts and may be executed by invoking the execute function.
Apart from the call target and the call data, it is possible to also specify the call value. However,
the PermissionProxy contract has no function allowing it to receive the native value. This
means that it is not possible for users to execute any call involving non-zero native value as all
such calls would revert.

Consider making the execute function payable or removing the value argument if the
PermissionProxy contract is not expected to make any calls with non-zero native value.

This implements the recommended fix by removing the value argument from PermissionProxy.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

linear bot commented Jun 17, 2024

@Reinis-FRP Reinis-FRP requested review from chrismaree and md0x June 17, 2024 13:10
Copy link
Member

@chrismaree chrismaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I think this is easier & safer

@Reinis-FRP Reinis-FRP changed the title fix[oval-audit-l-05]: remove value arg from permission proxy L-05 [Oval] PermissionProxy.execute Will Fail if Non-Zero value Is Provided Jun 17, 2024
Copy link
Collaborator

@md0x md0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reinis-FRP Reinis-FRP merged commit 77e5441 into master Jun 18, 2024
3 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis/uma-2650-l-05-oval-permissionproxyexecute-will-fail-if-non-zero-value branch June 18, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants