Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-13 [Oval] Misleading Comment #25

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

Reinis-FRP
Copy link
Collaborator

Addresses audit issue: N-13 [Oval] Misleading Comment

The following misleading comment has been identified:

In ChainlinkSourceAdapter.sol , this comment says that if the data returned by the
_searchRoundDataAt function is uninitialized, the current price data is returned. However,
the latest price data will also be returned in case the _searchRoundDataAt function returns
initialized data that is older than maxAge() .

Consider fixing the comment in order to improve the overall clarity and readability of the
codebase.

This implements the recommended fix by elaborating the comment in ChainlinkSourceAdapter.sol.

Signed-off-by: Reinis Martinsons <reinis@umaproject.org>
Copy link

linear bot commented Jun 17, 2024

@Reinis-FRP Reinis-FRP requested review from chrismaree and md0x June 17, 2024 14:26
@Reinis-FRP Reinis-FRP merged commit 5624e60 into master Jun 18, 2024
3 checks passed
@Reinis-FRP Reinis-FRP deleted the reinis/uma-2655-n-13-oval-misleading-comment branch June 18, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants