feat: update oval oracle #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
chrismaree
reviewed
Feb 6, 2024
chrismaree
reviewed
Feb 6, 2024
| @@ -3,7 +3,7 @@ pragma solidity 0.8.17; | |||
|
|
|||
| import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol"; | |||
| import {Address} from "@openzeppelin/contracts/utils/Address.sol"; | |||
| import {IAggregatorV3Source} from "oval-contracts/interfaces/chainlink/IAggregatorV3Source.sol"; | |||
| import {IAggregatorV3Source} from "oval-quickstart/ChainlinkOvalImmutable.sol"; | |||
There was a problem hiding this comment.
this is great! I love how simple this is to get the new logic.
chrismaree
reviewed
Feb 6, 2024
| @@ -2,11 +2,9 @@ | |||
|
|
|||
There was a problem hiding this comment.
do you think we should add some text about how searchers can make money from this? we could add it later I guess as well.
Co-authored-by: Chris Maree <christopher.maree@gmail.com>
mrice32
approved these changes
Feb 7, 2024
| --mnemonics "$MNEMONIC" \ | ||
| --sender $DEPLOYER_WALLET \ | ||
| --broadcast | ||
| export PRIVATE_KEY=0xPUT_YOUR_PRIVATE_KEY_HERE # This account will do the deployment |
There was a problem hiding this comment.
Do we allow both mnemonics and private keys? I feel like mnemonics are easier for the user
script/HoneyPot.s.sol
Outdated
| address chainlink = vm.envAddress("SOURCE_ADDRESS"); | ||
| uint256 lockWindow = vm.envUint("LOCK_WINDOW"); | ||
| uint256 maxTraversal = vm.envUint("MAX_TRAVERSAL"); | ||
| address unlocker = vm.envAddress("UNLOCKERS"); |
There was a problem hiding this comment.
In the README, this is called UNLOCKER, not UNLOCKERS. Since we only allow 1, I think UNLOCKER seems more correct.
| import {HoneyPot} from "../src/HoneyPot.sol"; | ||
| import {HoneyPotDAO} from "../src/HoneyPotDAO.sol"; | ||
| import {ChronicleMedianSourceMock} from "../src/mock/ChronicleMedianSourceMock.sol"; | ||
| import {ChainlinkOvalImmutable, IAggregatorV3Source} from "oval-quickstart/ChainlinkOvalImmutable.sol"; |
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
ChainlinkOvalImmutablefrom Oval-Quickstart repo