feat: add mock oracle #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
commented
Feb 13, 2024
|
|
||
| // This function is part of the AccessControlledOffchainAggregator interface. It is used to | ||
| // update the new price and look like a transmit function from a real Chainlink Aggregator | ||
| function transmit( |
There was a problem hiding this comment.
Added the transmit function from the AccessControlledOffchainAggregator so we don't need a second mock oracle.
By setting aggregator = address(this) in the constructor we mock the aggregator as well. This is useful for monitoring transmit calls in the backrunner mempool technique.
md0x
commented
Feb 13, 2024
| constructor(uint8 _decimals, int256 _initialAnswer) { | ||
| decimals = _decimals; | ||
| updateAnswer(_initialAnswer); | ||
| aggregator = address(this); // For simplicity, we set the aggregator address to the contract address |
There was a problem hiding this comment.
We use this mock contract as the aggregator where new prices are pushed
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
daywiss
approved these changes
Feb 15, 2024
| contract HoneyPotDeploymentScript is Script { | ||
| function run() external { | ||
| uint256 deployerPrivateKey = vm.envUint("PRIVATE_KEY"); | ||
| address chainlink = vm.envAddress("SOURCE_ADDRESS"); | ||
| address chainlink = vm.envOr("SOURCE_ADDRESS", address(0)); |
There was a problem hiding this comment.
can the app run with address 0? if not just throw if not provided
There was a problem hiding this comment.
If not provided it deploys a mock oracle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: