feat(gas-rebates): update gas rebate scripts with new rules #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
requested review from
mrice32,
chrismaree,
Reinis-FRP and
daywiss
as code owners
daywiss
reviewed
Feb 5, 2025
| const revealEventsMinBalance = revealEvents.filter((event) => event.args.numTokens.gte(minTokens)); | ||
|
|
||
| // Filter out duplicate commit events as we only refund the latest commit event per voter per round | ||
| const uniqueCommitEvents = new Map<string, VoteCommittedEvent>(); |
There was a problem hiding this comment.
this is interesting. ive had to sometimes commit more than once because theres so many votes sometimes. is this a technical or design decision
daywiss
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
looks good, im wondering if rather than taking last commit, we take most expensive commit. im thinking of the cases where i double commit, its usually because i missed one answer or felt i had to change it due to discussion, making the last commit usually cheaper than the original
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
changed the title
daywiss
approved these changes
Feb 12, 2025
| // Filter out duplicate commit events as we only refund the first commit event per voter per round | ||
| const uniqueCommitEvents = new Map<string, VoteCommittedEvent>(); | ||
|
|
||
| // Sort first by blockNumber (desc) and then by logIndex (desc) as a tiebreaker |
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR: